[PATCH] D125784: [llvm-debuginfo-analyzer] 09 - CodeView Reader

[Carlos Alberto Enciso via Phabricator via llvm-commits]

CarlosAlbertoEnciso added inline comments.


================
Comment at: llvm/include/llvm/DebugInfo/LogicalView/Readers/LVCodeViewVisitor.h:116
+private:
+  LVCodeViewReader *Reader = nullptr;
+  const llvm::object::coff_section *CoffSection;
----------------
probinson wrote:
> `Reader` is initialized in the constructor using a constructor parameter.
Removed the explicit initialization.


================
Comment at: llvm/include/llvm/DebugInfo/LogicalView/Readers/LVCodeViewVisitor.h:134
+class LVSymbolVisitor final : public SymbolVisitorCallbacks {
+  LVCodeViewReader *Reader = nullptr;
+  ScopedPrinter &W;
----------------
probinson wrote:
> `Reader` is explicitly initialized in the constructor.
Removed the explicit initialization.


================
Comment at: llvm/include/llvm/DebugInfo/LogicalView/Readers/LVCodeViewVisitor.h:140
+  LVSymbolVisitorDelegate *ObjDelegate;
+  LVShared *Shared = nullptr;
+
----------------
probinson wrote:
> `Shared` is explicitly initialized in the constructor.
Removed the explicit initialization.


================
Comment at: llvm/include/llvm/DebugInfo/LogicalView/Readers/LVCodeViewVisitor.h:149
+
+  bool HasIds = false;
+  bool InFunctionScope = false;
----------------
probinson wrote:
> `HasIds` is explicitly initialized in the constructor.
Removed the explicit initialization.


================
Comment at: llvm/include/llvm/DebugInfo/LogicalView/Readers/LVCodeViewVisitor.h:240
+class LVLogicalVisitor final {
+  LVCodeViewReader *Reader = nullptr;
+  ScopedPrinter &W;
----------------
probinson wrote:
> `Reader` is explicitly initialized in the constructor.
Removed the explicit initialization.


================
Comment at: llvm/include/llvm/DebugInfo/LogicalView/Readers/LVCodeViewVisitor.h:249
+
+  LVShared *Shared = nullptr;
+
----------------
probinson wrote:
> `Shared` is explicitly initialized in the constructor.
Removed the explicit initialization.


================
Comment at: llvm/lib/DebugInfo/LogicalView/Readers/LVCodeViewVisitor.cpp:314
+  LVCodeViewReader *Reader = nullptr;
+  LVLogicalVisitor *Visitor = nullptr;
+  LVForwardReferences ForwardReferences;
----------------
probinson wrote:
> Reader and Visitor are initialized by the constructor, so remove `= nullptr` here.
Removed the explicit initialization.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125784/new/

https://reviews.llvm.org/D125784