[PATCH] D92132: [LV] Support widened induction variables in epilogue vectorization.

Venkataramanan Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 12 03:40:18 PDT 2022


venkataramanan.kumar.llvm added a comment.

Just one question otherwise patch looks good to me.



================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:10528
+            ResumeV = MainILV.createInductionResumeValue(
+                IndPhi, *ID, {EPI.MainLoopIterationCountCheck});
           }
----------------
Just a question here we are creating induction resume values two times for the main vector loop.  One here while setting up resume value for epilog vector loop. The second one while setting up resume value for the scalar loop.  is it possible to reuse already created one? 

If implementing the reuse is not worth the effort than creating a new one please ignore my comment. 




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92132/new/

https://reviews.llvm.org/D92132



More information about the llvm-commits mailing list