[PATCH] D135446: [libcxxabi] Resync llvm & libcxxabi's demangler

Alexey Bader via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 12 02:52:36 PDT 2022


bader accepted this revision.
bader added subscribers: steffenlarsen, jcranmer-intel.
bader added a comment.
This revision is now accepted and ready to land.

@urnathan, sorry, we didn't notice that https://reviews.llvm.org/D130909 introduces divergence. @steffenlarsen, @jcranmer-intel, FYI.
Regarding dropping LLVM_ prefix from header guards, it looks like these were removed with some automatic tool (https://github.com/intel/llvm/commit/c13a09a462807936f9eb17cc64f53ad7c9e8ddec), so I would expect someone else will run the tool again and add them back. Any ideas how to prevent this type of changes in the future? Maybe we can keep LLVM_ prefix for sources in llvm/ directory and just ignore this difference. What do you think?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135446/new/

https://reviews.llvm.org/D135446



More information about the llvm-commits mailing list