[PATCH] D133914: [InlineAsm][bugfix] Correct function addressing in inline asm

[Xiang Zhang via Phabricator via llvm-commits]

xiangzhangllvm added inline comments.


================
Comment at: llvm/lib/IR/InlineAsm.cpp:72
+  // TODO: refine me, unify the delimiter or handle all cases.
+  if (AsmStrs.empty())
+    AsmStr.split(AsmStrs, "\0A", -1, false);
----------------
pengfei wrote:
> When split failed, the size of AsmStrs is 1 rather than empty.
That is really a defect for inline asm use various delimiters : (
Let me update here, thanks.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133914/new/

https://reviews.llvm.org/D133914