[PATCH] D135738: [InstCombine] Bail out of casting calls when a conversion to byval is involved.

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

I don't think your patch completely solves the issue you're describing.  What happens if you have a struct where the only member is a pointer?  clang will lower it to "ptr", rust will lower it to "ptr byval", and whatever LTO side-effects you're seeing will happen without this instcombine transform ever getting involved.

Not sure what the right solution looks like here; the current CallBase::getCalledFunction() isn't really designed to consider this case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135738/new/

https://reviews.llvm.org/D135738