[PATCH] D135710: [lto] Do not try to internalize symbols with escaped name
serge via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 11 22:49:40 PDT 2022
serge-sans-paille added a comment.
In D135710#3850973 <https://reviews.llvm.org/D135710#3850973>, @tejohnson wrote:
> We call GlobalValue::dropLLVMManglingEscape on the IRName before computing the GUID for both regular and thin LTO in LTO.cpp. Do you know why this isn't handling this case?
It's because link time mangling can add various prefixes to symbols, see https://llvm.org/docs/LangRef.html#data-layout , `m:<mangling>` section. Basically for visible symbols, `GlobalValue::dropLLVMManglingEscape ` acts as un unmangler for ELF symbols. But it's not the case for other manglers.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135710/new/
https://reviews.llvm.org/D135710
More information about the llvm-commits
mailing list