[PATCH] D134367: [test][LoongArch] Mark old JIT ExecutionEngine tests as unsupported

Lu Weining via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 11 22:32:11 PDT 2022


SixWeining added reviewers: rengolin, MaskRay, lhames.
SixWeining added subscribers: MaskRay, lhames, rengolin.
SixWeining added a comment.
Herald added a subscriber: StephenFan.

In D134367#3814421 <https://reviews.llvm.org/D134367#3814421>, @xen0n wrote:

> In D134367#3807481 <https://reviews.llvm.org/D134367#3807481>, @SixWeining wrote:
>
>> Do you mean that new archs will never get supported by MCJIT?  Is there an announcement?
>>
>> But it seems true because I find this MR for llvmpipe adding orcjit support for riscv: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17801
>
> I forgot where I read this, but I believe this is the case. Seeing thriving architectures like AArch64 and RISCV here also explains things...

I see related discussion here: https://discourse.llvm.org/t/ive-seen-orcjit-is-under-overhaul-and-also-the-mcjit-so-whats-the-plan/48995/2
But I'm not sure about this. MCJIT doesn't accept new architectures any more? What do you think? @rengolin @MaskRay @lhames

BTW,  ExecutionEngine regression tests are enabled on AArch64 by a recent (last week) commit:

  commit 23dda2899efc784ec8510a8a7b28901bc4c7c8b8
  Author: Lang Hames <lhames at gmail.com>
  Date:   Tue Oct 4 11:31:09 2022 -0700
  
      [ExecutionEngine] Enable ExecutionEngine regression tests on AArch64.
  
  diff --git a/llvm/test/ExecutionEngine/lit.local.cfg b/llvm/test/ExecutionEngine/lit.local.cfg
  index 3338d19e967f..b00ef0dcbdf0 100644
  --- a/llvm/test/ExecutionEngine/lit.local.cfg
  +++ b/llvm/test/ExecutionEngine/lit.local.cfg
  @@ -1,4 +1,4 @@
  -if config.root.native_target in ['Sparc', 'PowerPC', 'AArch64', 'ARM64', 'SystemZ', 'Hexagon', 'RISCV']:
  +if config.root.native_target in ['Sparc', 'PowerPC', 'SystemZ', 'Hexagon', 'RISCV']:
       config.unsupported = True


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134367/new/

https://reviews.llvm.org/D134367



More information about the llvm-commits mailing list