[PATCH] D135590: [ThinLTO][ELF] Add a ThinLTO warning if cache_size_bytes or cache_size_files is too small for the current link job.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/ELF/LTO.cpp:204
+  if (Policy.MaxSizeFiles && (files.size() > Policy.MaxSizeFiles))
+    WithColor::warning()
+        << "ThinLTO cache pruning happens since the total number of the files "
----------------
`message(`

Drop trailing `.`. Please follow the style of other messages and diagnostics.

Be terse in some wording; suggest `the number of created files (number) exceeds the maximum ... (number)`


================
Comment at: lld/test/ELF/lto/cache-warnings.ll:2
+; REQUIRES: x86
+; NetBSD: noatime mounts currently inhibit 'touch' from updating atime
+; UNSUPPORTED: system-netbsd
----------------
Non-RUN non-CHECK comments use `;;` for new tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135590/new/

https://reviews.llvm.org/D135590