[PATCH] D135437: [Tests] Require zlib for zstd tests

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In D135437#3848749 <https://reviews.llvm.org/D135437#3848749>, @jhenderson wrote:

> I'm fairly confident this is the wrong fix for the problem. ZSTD compression shouldn't require ZLIB support (and similarly ZLIB compression shouldn't require ZSTD support). Without looking too hard at the problem, my guess is that there's a bug in the check for whether the --compress-debug-sections option is supported or not. There may also be a lit bug, in that the REQUIRES directive for these compression formats should be based on what happened at cmake configuration time, not (only) on what's installed on the system, but I'm not really sure.
>
> I haven't been involved with the recent compression changes really, so I've added a few people who have.

I agree with the analysis. https://reviews.llvm.org/D135744 is the proper fix.

The test/MC/ELF test works as intended, even if I enable zstd and disable zlib.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135437/new/

https://reviews.llvm.org/D135437