[PATCH] D133850: [AArch64] Improve codegen for "trunc <4 x i64> to <4 x i8>" for all cases

Sheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 11 18:08:20 PDT 2022


0x59616e added a comment.

In D133850#3849932 <https://reviews.llvm.org/D133850#3849932>, @mingmingl wrote:

> Hi, I realize D133280 <https://reviews.llvm.org/D133280> is a diffbase from the 'stack' UI, and actually I never figured out how to send stack reviews over others' patches, so didn't know if a) or b) is a simpler procedure
> a) for me to submit D133280 <https://reviews.llvm.org/D133280> first b) you could just commit all changes reviewed in this patch.
>
> Since this patch supersedes the test-only patch, I'm fine with a) or b), whichever makes the procedure simpler. Just let me know :)

I think it is best to do the same reviewing procedure as this on D133280 <https://reviews.llvm.org/D133280>, and commit it first.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133850/new/

https://reviews.llvm.org/D133850



More information about the llvm-commits mailing list