[PATCH] D135710: [lto] Do not try to internalize symbols with escaped name

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 11 15:44:43 PDT 2022


int3 added a comment.

`dropLLVMManglingEscape` drops the `\01` but doesn't drop the `_` prefix. I *think* this prefix is only used on Mach-O and not ELF?

Basically in Mach-O, the un-mangled names `\01_foo` and `foo` map to the same mangled name `_foo`. `dropLLVMManglingEscape("\01_foo")` gives us back `_foo` which doesn't match `foo`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135710/new/

https://reviews.llvm.org/D135710



More information about the llvm-commits mailing list