[PATCH] D130357: [MC,llvm-objdump,ARM] Target-dependent disassembly resync policy.

Scott Linder via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 11 15:05:41 PDT 2022


scott.linder added inline comments.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1073
     uint64_t Size;
-    DisAsm->getInstruction(Inst, Size, Bytes.slice(Index), SectionAddr + Index,
-                           nulls());
+    ArrayRef<uint8_t> ThisBytes = Bytes.slice(Index - SectionAddr);
+    DisAsm->getInstruction(Inst, Size, ThisBytes, Index, nulls());
----------------
@simon_tatham was this change intended? There is a fix at https://reviews.llvm.org/D135430 and I wanted to ping you in case we missed something.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130357/new/

https://reviews.llvm.org/D130357



More information about the llvm-commits mailing list