[PATCH] D135611: [llvm] Update WPD tests to use opaque pointers

Leonard Chan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 11 14:07:51 PDT 2022


leonardchan added a comment.

In D135611#3847626 <https://reviews.llvm.org/D135611#3847626>, @tejohnson wrote:

> Thanks. Per https://llvm.org/docs/OpaquePointers.html#version-support it sounds like non-opaque pointers are now only best effort and no longer need to be tested, since LLVM 15 has branched - is that correct?

Waiting for confirmation on this. On that page, it also mentions that typed pointers will not be supported for llvm 16, so I'm not entirely sure if tests will need to be migrated as well. Ideally, I'd like to ensure any tests I add for relative vtables + [thin]lto match the existing tests for regular vtables. If these tests can stay the same with typed pointers, then I'll need to ensure some syntax involving `dso_local_equivalent` work with typed pointers to ensure test parity. Otherwise,  I can ignore changes like D135483 <https://reviews.llvm.org/D135483> and only support opaque pointers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135611/new/

https://reviews.llvm.org/D135611



More information about the llvm-commits mailing list