[PATCH] D135710: [lto] Do not try to internalize symbols with escaped name

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 11 13:53:38 PDT 2022


int3 added a comment.

My bad, I had a proper look and yeah this seems to do the right thing.

I'm wondering if the test should use `llvm-lto` instead of `ld64.lld` (and placed under `llvm/test/LTO`) since this is technically not an LLD-specific issue. I don't feel strongly about it though.

If we are keeping the test under `lld/`, I would prefer we combined both test files into one (relying more on `split-file`).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135710/new/

https://reviews.llvm.org/D135710



More information about the llvm-commits mailing list