[PATCH] D135674: [NVPTX] Fix pointer argument declaration for --nvptx-short-ptr

[Artem Belevich via Phabricator via llvm-commits]

tra added inline comments.


================
Comment at: llvm/lib/Target/NVPTX/NVPTXAsmPrinter.cpp:1536
+            TLI->getPointerTy(DL, PTy->getAddressSpace()).getSizeInBits();
+      }
+
----------------
Should there be an `else PTySizeInBits =    TLI->getPointerTy(DL).getSizeInBits()` ?



================
Comment at: llvm/lib/Target/NVPTX/NVPTXAsmPrinter.cpp:1585
       } else if (isa<PointerType>(Ty))
-        sz = thePointerTy.getSizeInBits();
+        sz = PTySizeInBits;
       else if (Ty->isHalfTy())
----------------
`assert(PTySizeInBits)` ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135674/new/

https://reviews.llvm.org/D135674