[PATCH] D135530: [lld-macho] Add --ignore-auto-link-option

[Jez Ng via Phabricator via llvm-commits]

int3 accepted this revision.
int3 added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: lld/MachO/Config.h:172
   bool ignoreAutoLink = false;
+  llvm::StringSet<> ignoreAutoLinkOptions;
   PlatformInfo platformInfo;
----------------
can we have a comment explaining the motivation behind this option?


================
Comment at: lld/MachO/Options.td:997-1002
+def ignore_auto_link_option : Separate<["--"], "ignore-auto-link-option">,
+    Group<grp_rare>;
+def ignore_auto_link_option_eq : Joined<["--"], "ignore-auto-link-option=">,
+    Alias<!cast<Separate>(ignore_auto_link_option)>,
+    HelpText<"Ignore a single auto-linked library or framework. Useful to ignore invalid requirements that ld64 ignores">,
+    Group<grp_rare>;
----------------
this should be under `grp_lld` (and moved to the top of the file with the rest of the options in that group)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135530/new/

https://reviews.llvm.org/D135530