[PATCH] D135686: [AArch64] Exclude instructions after setting the FP from SEH prologues

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.cpp:4350
+        if (HasWinCFI)
+          *HasWinCFI = true;
         assert(SrcReg == AArch64::SP && "Unexpected SrcReg for SEH_StackAlloc");
----------------
mstorsjo wrote:
> efriedma wrote:
> > I don't think you need to revert the part of the change involving the redundant `*HasWinCFI = true;`?
> Oh, right. I noted that after removing the else case, there’s one possible codepath where no SEH opcodes are added, and we perhaps shouldn’t be setting `HasWinCFI`, but apparently we had that inconsistency before this change. So either we should remove the catch-all setting of it below to remove the inconsistency, or just leave that part as it is.
Whatever you think makes sense.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135686/new/

https://reviews.llvm.org/D135686