[PATCH] D135693: [WIP][RegisterScavenger][RISCV] Don't search for FrameSetup instrs if we were searching from Non-FrameSetup instrs

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 11 09:56:09 PDT 2022


craig.topper added inline comments.


================
Comment at: llvm/lib/CodeGen/RegisterScavenging.cpp:378
+    // Non-FrameSetup instructions. Otherwise, the spill position may point to
+    // where before FrameSetup instructions.
+    if (!From->getFlag(MachineInstr::FrameSetup) &&
----------------
I think "to where" should be removed from this sentence.


================
Comment at: llvm/lib/CodeGen/RegisterScavenging.cpp:380
+    if (!From->getFlag(MachineInstr::FrameSetup) &&
+        I->getFlag(MachineInstr::FrameSetup))
+      break;
----------------
Use `MI.getFlag`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135693/new/

https://reviews.llvm.org/D135693



More information about the llvm-commits mailing list