[PATCH] D135596: [AArch64] Canonicalize ZERO_EXTEND to VSELECT
Nicola Lancellotti via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 11 09:24:21 PDT 2022
NicolaLancellotti added a comment.
In D135596#3848253 <https://reviews.llvm.org/D135596#3848253>, @paulwalker-arm wrote:
> Given you want to canonicalise to vselect is it worth doing this during lowering and removing the existing zext isel pattern? that way we can be sure all instances use the same idiom? This looks like it would be equally useful for sign_extend's of predicates also?
Paul, thank you very much for the review.
I moved the code so that the canonicalisation is done during the lowering, and I removed the existing zext isel pattern.
You are right, it would be useful for sign_extend too, I'll create another patch later.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135596/new/
https://reviews.llvm.org/D135596
More information about the llvm-commits
mailing list