[PATCH] D135642: [MC] .addrsig_sym: ignore unregistered symbols

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

If we have this, should we revert D101512 <https://reviews.llvm.org/D101512> as a code simplification?

Please update the .addrsig docs available at https://llvm.org/docs/Extensions.html#machine-specific-assembly-syntax to document that symbols that are neither defined nor referenced are not recorded as address-significant.

Also, I'm starting to reconsider D135427 <https://reviews.llvm.org/D135427>, which made non-prevailing local comdat members available_externally. Why did you choose available_externally? That is an external linkage. If there are any references to the local linkage symbol, they will now become references to an external symbol with the same name, rather than becoming errors, or relocations against discarded sections. The native linker *discards* non-prevailing comdat members, so we should do that too in complex cases. Using available_externally is something we do to support optimization (inlining).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135642/new/

https://reviews.llvm.org/D135642