[llvm] 3648fc5 - [AMDGPU] Make disassembler convertFMAanyK call more generic

Joe Nash via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 11 08:22:40 PDT 2022


Author: Joe Nash
Date: 2022-10-11T11:22:25-04:00
New Revision: 3648fc5b42bd2c320cb49004cd9c40cd32a44384

URL: https://github.com/llvm/llvm-project/commit/3648fc5b42bd2c320cb49004cd9c40cd32a44384
DIFF: https://github.com/llvm/llvm-project/commit/3648fc5b42bd2c320cb49004cd9c40cd32a44384.diff

LOG: [AMDGPU] Make disassembler convertFMAanyK call more generic

Make support more generic to support future instructions.
Currently NFC.

Reviewed By: foad, arsenm

Differential Revision: https://reviews.llvm.org/D135678

Added: 
    

Modified: 
    llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp b/llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp
index 9011b4bc692a9..4745a35ebdea8 100644
--- a/llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp
+++ b/llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp
@@ -704,8 +704,8 @@ DecodeStatus AMDGPUDisassembler::getInstruction(MCInst &MI, uint64_t &Size,
 
   int ImmLitIdx =
       AMDGPU::getNamedOperandIdx(MI.getOpcode(), AMDGPU::OpName::imm);
-  bool isVOP2 = MCII->get(MI.getOpcode()).TSFlags & SIInstrFlags::VOP2;
-  if (Res && ImmLitIdx != -1 && (isVOP2 || AMDGPU::isVOPD(MI.getOpcode())))
+  bool IsSOPK = MCII->get(MI.getOpcode()).TSFlags & SIInstrFlags::SOPK;
+  if (Res && ImmLitIdx != -1 && !IsSOPK)
     Res = convertFMAanyK(MI, ImmLitIdx);
 
   // if the opcode was not recognized we'll assume a Size of 4 bytes


        


More information about the llvm-commits mailing list