[PATCH] D135655: [AArch64][SVE] Fix BRKNS bug in optimizePTestInstr

Cullen Rhodes via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 11 08:13:46 PDT 2022


c-rhodes marked 2 inline comments as done.
c-rhodes added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.cpp:1359
+      // Must be an all active predicate of matching element size (.b).
+      if ((PredElementSize != MaskElementSize) || !isPTrueOpcode(MaskOpcode) ||
+          (Mask->getOperand(1).getImm() != 31))
----------------
paulwalker-arm wrote:
> What about "(MaskOpcode != AArch64::PTRUE_B)"?
> What about "(MaskOpcode != AArch64::PTRUE_B)"?

that makes more sense, done


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135655/new/

https://reviews.llvm.org/D135655



More information about the llvm-commits mailing list