[PATCH] D135655: [AArch64][SVE] Fix BRKNS bug in optimizePTestInstr

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.cpp:1359
+      // Must be an all active predicate of matching element size (.b).
+      if ((PredElementSize != MaskElementSize) || !isPTrueOpcode(MaskOpcode) ||
+          (Mask->getOperand(1).getImm() != 31))
----------------
What about "(MaskOpcode != AArch64::PTRUE_B)"?


================
Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.cpp:1363-1364
 
+      assert((MaskElementSize == AArch64::ElementSizeB) &&
+             "Unexpected element size!");
+
----------------
With the above I doubt we need this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135655/new/

https://reviews.llvm.org/D135655