[PATCH] D135678: [AMDGPU] Make disassembler convertFMAanyK call more generic

Joe Nash via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 11 07:48:19 PDT 2022


Joe_Nash created this revision.
Joe_Nash added reviewers: dp, foad.
Herald added subscribers: kosarev, kerbowa, hiraditya, t-tye, tpr, dstuttard, yaxunl, jvesely, kzhuravl, arsenm.
Herald added a project: All.
Joe_Nash requested review of this revision.
Herald added subscribers: llvm-commits, wdng.
Herald added a project: LLVM.

Make support more generic to support future instructions.
Currently NFC.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D135678

Files:
  llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp


Index: llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp
===================================================================
--- llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp
+++ llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp
@@ -704,8 +704,8 @@
 
   int ImmLitIdx =
       AMDGPU::getNamedOperandIdx(MI.getOpcode(), AMDGPU::OpName::imm);
-  bool isVOP2 = MCII->get(MI.getOpcode()).TSFlags & SIInstrFlags::VOP2;
-  if (Res && ImmLitIdx != -1 && (isVOP2 || AMDGPU::isVOPD(MI.getOpcode())))
+  bool IsSOPK = MCII->get(MI.getOpcode()).TSFlags & SIInstrFlags::SOPK;
+  if (Res && ImmLitIdx != -1 && !IsSOPK)
     Res = convertFMAanyK(MI, ImmLitIdx);
 
   // if the opcode was not recognized we'll assume a Size of 4 bytes


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D135678.466817.patch
Type: text/x-patch
Size: 752 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221011/2b9775cb/attachment.bin>


More information about the llvm-commits mailing list