[PATCH] D132458: [LoopVectorize] Support masked function vectorization

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 11 07:02:54 PDT 2022


fhahn added reviewers: Ayal, gilr.
fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/VPlanRecipes.cpp:478
+      // TODO: Do we need TTI checks for masking here? Or can we
+      // assume it works by this point? Maybe add to the recipe...
+      if (!VectorF) {
----------------
It would be good if the decision whether to used the masked or non-masked variant would be taken at the time of VPlan construction instead of during executing.

 It would probably also be good to pass in the mask as operand to the recipe, especially if we want to support non-trivial masks in the future.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132458/new/

https://reviews.llvm.org/D132458



More information about the llvm-commits mailing list