[PATCH] D134195: [PowerPC] XCOFF exception section support on the integrated assembler path

Tue Oct 11 07:00:38 PDT 2022

pscoro marked an inline comment as done.
pscoro added inline comments.

================
Comment at: llvm/include/llvm/MC/MCObjectWriter.h:108

+  virtual void addExceptionEntry(const MCSymbol *Symbol, MCSymbol *Trap,
+                                 unsigned LanguageCode, unsigned ReasonCode,
----------------
tschuett wrote:
> pscoro wrote:
> > tschuett wrote:
> > > Is this going to be an XCOFF only function?
> > Yes, exception sections are an XCOFF only feature. The specifics can be found in the XCOFF documentation: https://www.ibm.com/docs/en/aix/7.2?topic=formats-xcoff-object-file-format#d236277e7374
> In the other diff, there was a report_fatal_error if used by other than XCOFF.
Yep, the other diff had a fatal error for emitXCOFFExceptDirective, a similar error was needed here, good catch thanks.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134195/new/

https://reviews.llvm.org/D134195