[PATCH] D135656: [IR] Add nocapture to pointer parameters of masked stores/loads

[Peter Waller via Phabricator via llvm-commits]

peterwaller-arm added a comment.

(Full disclosure: Ben is a new colleague of mine)

Welcome to upstream LLVM! Thanks for your first patch. The change looks good to me, but you'll need to include unit tests that defend this behaviour before this can be accepted. This has the dual benefit of making it clear in the patch what this is trying to achieve and prevents someone from breaking the code you're trying to improve in the future. Tests are found in test/Transforms/InstCombine. There are a few files in that directory with the name 'alloca' in them, and you can probably add to one of those.  Please take a look.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135656/new/

https://reviews.llvm.org/D135656