[PATCH] D135578: [CMake] Add option LLVM_FORCE_CREATE_SYMLINKS

[Tobias Hieta via Phabricator via llvm-commits]

thieta added a comment.

In D135578#3848706 <https://reviews.llvm.org/D135578#3848706>, @mstorsjo wrote:

> This looks reasonable to me (although I haven't dug through the code to see if there are more cases that would need to be set in sync). Is it kosher to add new end-user options like this in a nested cmake module file?
>
> I'll leave it open for @phosek to comment on in any case.

There are other places where symlinks are used and some similar logic is being applied - like here: 
https://github.com/llvm/llvm-project/blob/main/compiler-rt/lib/builtins/CMakeLists.txt#L533

I am not sure it's worth to fix this at the same time since that has to do with symlinking the files when building rather then the finished distribution.

Regarding option() in this cmakefile - I had the same idea, but I saw several option() calls in this file already, so I figured it was a pattern already.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135578/new/

https://reviews.llvm.org/D135578