[PATCH] D131593: [CMake] Update FindGPRC to use add_llvm_library

Sam McCall via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 10 15:27:35 PDT 2022


sammccall added a comment.

In D131593#3847986 <https://reviews.llvm.org/D131593#3847986>, @rymiel wrote:

> @sammccall
>
>> That said, this sort of change can break somewhat obscure configurations and may need a fix/revert at some later point
>
> Could you please have a look at https://github.com/llvm/llvm-project/issues/58075? I feel like my configuration isn't obscure, I'm simply trying to use LLVM as a CMake library, but I doubt myself because something that simple should have been caught by other people.

@steven_wu are you able to take a look at this?

I'm not familiar with consuming LLVM as a library through CMake.

A glance through the macros suggests maybe we want to pass `BUILDTREE_ONLY` to add_llvm_library, but that's a complete guess.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131593/new/

https://reviews.llvm.org/D131593



More information about the llvm-commits mailing list