[PATCH] D135038: [lld/mac] Port typo correction for undefined symbols from ELF port

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

(FWIW, my 2c & this dates back to the founding of the 'new' (now not-so-new) lld - that the code duplication between ports is pretty unfortunate & while it does give some agility to the ports to work differently because they are different - it also means code diverges, bugfixes get made in one port and not shared by others - all the usual reasons code duplication is problematic & that LLVM as a whole has been founded on reusable library abstractions that have been quite effective/beneficial overall - I'd love to see even small parts of lld start to be abstracted into common helpers even with some trait adapters to handle the trivial differences in naming and/or some pressure to make the naming consistent and keep it that way at least in subsets of the API (eg: enough to make this work as a template) - but you folks can take this for whatever it's worth/weigh it against all your other goals/needs)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135038/new/

https://reviews.llvm.org/D135038