[llvm] 4b599fa - [SCEV] Verify block disposition cache.

[Florian Hahn via llvm-commits]

Author: Florian Hahn
Date: 2022-10-10T20:42:19+01:00
New Revision: 4b599fa1ee240f5e9de4242294a5bbc2981491b4

URL: https://github.com/llvm/llvm-project/commit/4b599fa1ee240f5e9de4242294a5bbc2981491b4
DIFF: https://github.com/llvm/llvm-project/commit/4b599fa1ee240f5e9de4242294a5bbc2981491b4.diff

LOG: [SCEV] Verify block disposition cache.

This extends the existing SCEV verification to catch cache invalidation
issues as in #57837.

The validation logic is similar to the recently added loop disposition
cache validation in bb68b2402daa9.

Reviewed By: nikic

Differential Revision: https://reviews.llvm.org/D134531

Added: 
    

Modified: 
    llvm/lib/Analysis/ScalarEvolution.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Analysis/ScalarEvolution.cpp b/llvm/lib/Analysis/ScalarEvolution.cpp
index 189245ef10754..d8ba9c6cd297a 100644
--- a/llvm/lib/Analysis/ScalarEvolution.cpp
+++ b/llvm/lib/Analysis/ScalarEvolution.cpp
@@ -14021,6 +14021,22 @@ void ScalarEvolution::verify() const {
       }
     }
   }
+
+  // Verify integrity of the block disposition cache.
+  for (const auto &It : BlockDispositions) {
+    const SCEV *S = It.first;
+    auto &Values = It.second;
+    for (auto &V : Values) {
+      auto CachedDisposition = V.getInt();
+      const BasicBlock *BB = V.getPointer();
+      const auto RecomputedDisposition = SE2.getBlockDisposition(S, BB);
+      if (CachedDisposition != RecomputedDisposition) {
+        dbgs() << "Cached disposition of " << *S << " for block %"
+               << BB->getName() << " is incorrect! \n";
+        std::abort();
+      }
+    }
+  }
 }
 
 bool ScalarEvolution::invalidate(