[PATCH] D134279: [MustExec][LICM] Handle latch being part of an inner cycle (PR57780)

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.





================
Comment at: llvm/lib/Analysis/MustExecute.cpp:204
 
+  // Bail out if the latch block is part of the predecessor set. In this case
+  // we may take the backedge to the header and not execute other latch
----------------
Should this say `latch blocks`?

Also, `predecessors(CurLoop->getHeader()` will include non-latch blocks (i.e. predecessors not in the loop). I suppose it doesn't matter in practice as `Predecessors` only contains loop blocks but it might be possible to include this in the comment somehow?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134279/new/

https://reviews.llvm.org/D134279