[PATCH] D135539: llvm-reduce: Don't write out IR to score IR complexity

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 10 12:25:47 PDT 2022


arsenm added a comment.

In D135539#3847581 <https://reviews.llvm.org/D135539#3847581>, @aeubanks wrote:

>> note that there exist some flags where the presence of the flag is semantically simpler than the absence of the flag! for example, a noundef function parameter can make a function considerably easier to understand. that's one of the things I disliked about the previous "file size" approach. could you please add some TODO/FIXME items regarding that sort of thing?
>
> IMO we should still be reducing away those attributes, if somebody submitted a test case I'd request irrelevant attributes to be removed

My struggle is I don't actually care about the IR on most failures I end up looking at, and want to minimize the MIR that comes out of it. Any annotations that decrease the emitted machine code are useful. One simple example is marking globals as internal/protected to avoid the GOT lookup


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135539/new/

https://reviews.llvm.org/D135539



More information about the llvm-commits mailing list