[PATCH] D135483: [llvm][LLParser] Fix issue with forward-referenced dso_local_equivalent globals

[Leonard Chan via Phabricator via llvm-commits]

leonardchan added a comment.

In D135483#3844223 <https://reviews.llvm.org/D135483#3844223>, @aeubanks wrote:

> can we migrate the WPD tests to use opaque pointers? https://gist.github.com/nikic/98357b71fd67756b0f064c9517b62a34 is the script to do that

Uploaded https://reviews.llvm.org/D135611 which updates everything under `llvm/test/Transforms/WholeProgramDevirt/`. Needed some non-trivial manual updating though for a handful of tests. I suspect I'll run into more failures requiring manual tuning if I were to update the thinlto tests as well. What's the current plan for migrating llvm tests to unique pointers? I see on the opaque ptrs doc <https://llvm.org/docs/OpaquePointers.html#version-support> that by llvm 16, type pointers will no longer be supported but it looks like there's still a lot of llvm tests that still use typed pointers. Will all of them go through a mass migration using this script? One worry I have is I (or other test owners) will need to spend a non-trivial amount of time fixing tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135483/new/

https://reviews.llvm.org/D135483