[PATCH] D135572: [Attributes] Support int attributes with zero value

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks accepted this revision.
aeubanks added a comment.
This revision is now accepted and ready to land.

one nit, otherwise lgtm



================
Comment at: llvm/lib/IR/Attributes.cpp:102
+  else
+    assert(Val == 0 && "Value must be zero for enum attributes");
 
----------------
seems dangerous to put `assert` in the else branch without parentheses, it might expand to nothing?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135572/new/

https://reviews.llvm.org/D135572