[PATCH] D135606: llvm-reduce: Improve delta pass flag handling

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added inline comments.


================
Comment at: llvm/tools/llvm-reduce/DeltaManager.cpp:134
 #undef DELTA_PASS
   errs() << "unknown pass \"" << PassName << "\"\n";
   exit(1);
----------------
now unreachable?


================
Comment at: llvm/tools/llvm-reduce/DeltaManager.cpp:159
 
+static void splitCSV(SmallVectorImpl<StringRef> &PassNames, StringRef Passes) {
+  while (!Passes.empty()) {
----------------
there's already a `StringRef::split` overload that does this

there's also `cl::CommaSeparated` as part of `cl::opt`


================
Comment at: llvm/tools/llvm-reduce/DeltaManager.cpp:188-189
+
+  SmallStringSet RunPassSet, SkipPassSet;
+  SmallVector<StringRef> RunPassList, SkipPassList;
+
----------------
with `cl::CommaSeparated` it should be easier to just create a set for skipped and just a list for RunPassList.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135606/new/

https://reviews.llvm.org/D135606