[PATCH] D135591: [SLP]Fix insertpoint of the extractellements instructions to avoid reshuffle crash.

Alexey Bataev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 10 09:16:31 PDT 2022


ABataev added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:7677
 
-  auto &&FindFirstInst = [E, Front]() {
+  auto &&FindFirstInst = [E, Front, this]() {
     Instruction *FirstInst = Front;
----------------
RKSimon wrote:
> At what point when extending a capture list should we just use [&]? @dblaikie was commenting on this not so long ago.
I don't see any rules related to the list of captures in LLVM coding standard https://llvm.org/docs/CodingStandards.html


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135591/new/

https://reviews.llvm.org/D135591



More information about the llvm-commits mailing list