[PATCH] D135478: [AMDGPU] Make V_SAT_PK_U8_I16 a True16 Instruction

Mon Oct 10 07:33:25 PDT 2022

Joe_Nash added a comment.

In D135478#3844280 <https://reviews.llvm.org/D135478#3844280>, @arsenm wrote:

> In D135478#3843621 <https://reviews.llvm.org/D135478#3843621>, @Joe_Nash wrote:
>
>> It's not clear to me if this instruction was ever selected. I don't see any ISel pattern or reference in tablegen or c++. In the synthesized tablgen defs, I see list<dag> Pattern = [(set i32:$vdst, (null_frag (i32 (VOP3Mods0 i32:$src0))))]; which I think doesn't get used because of the null_frag? Anyway, if it is being selected, do I need to update the pattern for the type change?
>
> If it's not getting selected, it probably should be. I believe this corresponds to llvm.sadd.sat

Thanks. I made an issue for this https://github.com/llvm/llvm-project/issues/58266

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135478/new/

https://reviews.llvm.org/D135478