[PATCH] D135580: utils/update_mir_test_checks.py: support UTC_ARGS

Gaƫtan Bossu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 10 06:54:36 PDT 2022


gbossu created this revision.
Herald added a subscriber: arichardson.
Herald added a project: All.
gbossu requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

As a reminder, UTC_ARGS is used by lit test cases to specify which
arguments need to be passed to update_XXXX_test_checks.py to be
auto-updated properly.

The support is achieved by relying on common.itertests, which is what other test
updaters use to iterate over test files.

This commit also changes how the --llc-binary option is saved in args.
It used to be saved as "llc", but it is here changed to the standard
"llc_binary" to make use of an existing ignore mechanism for specific
arguments. Without that change, the option would not be ignored and
would appear in UTC_ARGS. This would be different from what e.g.
update_llc_test_checks does. As update_mir_test_checks.py now supports
UTC_ARGS, it became important to ensure the option is ignored.

Depends on D135579 <https://reviews.llvm.org/D135579>


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D135580

Files:
  llvm/test/tools/UpdateTestChecks/update_mir_test_checks/Inputs/print-stack-update.mir
  llvm/test/tools/UpdateTestChecks/update_mir_test_checks/Inputs/print-stack.mir.expected
  llvm/test/tools/UpdateTestChecks/update_mir_test_checks/print-stack.test
  llvm/utils/update_mir_test_checks.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D135580.466489.patch
Type: text/x-patch
Size: 5972 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221010/eca1e4ca/attachment.bin>


More information about the llvm-commits mailing list