[PATCH] D133914: [InlineAsm][bugfix] Correct function addressing in inline asm
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 10 05:25:57 PDT 2022
RKSimon added inline comments.
================
Comment at: llvm/include/llvm/CodeGen/TargetLowering.h:3531
+ virtual bool
+ isInlineAsmTargetBranch(const SmallVectorImpl<StringRef> &AsmStrs,
+ unsigned OpNo) const {
----------------
Why not ArrayRef<StringRef> ?
================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:8724
+static bool isFunction(SDValue Op) {
+ if (Op.getNode() && Op.getOpcode() == ISD::GlobalAddress) {
+ if (auto *GA = dyn_cast<GlobalAddressSDNode>(Op)) {
----------------
SDValue has a bool operator so we don't need to use getNode()
```
if (Op && Op.getOpcode() == ISD::GlobalAddress) {
```
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133914/new/
https://reviews.llvm.org/D133914
More information about the llvm-commits
mailing list