[PATCH] D135523: Adds absolute and pc relative relocation support for ELF/i386

[Stefan Gränitz via Phabricator via llvm-commits]

sgraenitz accepted this revision.
sgraenitz added a comment.
This revision is now accepted and ready to land.

Thanks for working on this! Apart from the naming detail, the changes in ELFLinkGraphBuilder.h are looking good to me.



================
Comment at: llvm/lib/ExecutionEngine/JITLink/ELFLinkGraphBuilder.h:505
+Error ELFLinkGraphBuilder<ELFT>::forEachRelaRelocation(
+    const typename ELFT::Shdr &RelSect, RelocHandlerMethod &&Func,
     bool ProcessDebugSections) {
----------------
Nit: We should keep typename Function here as well as for forEachRelRelocation()


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135523/new/

https://reviews.llvm.org/D135523