[PATCH] D135550: [Coroutines] Don't merging readnone calls in presplit coroutines

[Chuanqi Xu via Phabricator via llvm-commits]

ChuanqiXu created this revision.
ChuanqiXu added reviewers: jdoerfert, nikic, fhahn, jyknight, nhaehnle, nlopes.
Herald added a subscriber: hiraditya.
Herald added a project: All.
ChuanqiXu requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Another alternative to fix the thread identification problem in coroutines.

We plan to fix this problem by unifying memory effecting attributes. See https://discourse.llvm.org/t/rfc-unify-memory-effect-attributes/65579.
But it may be a long-term project. And it is a pity that the coroutines can't resume in different threads for years. So this one is temporary fix. It may cause unnecessary performance regression for coroutines. But correctness are more important. And this one is planned to be reverted after we are able to unify the memory effecting attributes actually.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D135550

Files:
  llvm/docs/ReleaseNotes.rst
  llvm/lib/Transforms/Scalar/EarlyCSE.cpp
  llvm/lib/Transforms/Scalar/GVN.cpp
  llvm/lib/Transforms/Scalar/NewGVN.cpp
  llvm/test/Transforms/Coroutines/coro-readnone-02.ll
  llvm/test/Transforms/Coroutines/coro-readnone.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D135550.466415.patch
Type: text/x-patch
Size: 11269 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221010/211d12c9/attachment.bin>