[PATCH] D131518: Make opt-viewer more usable by general developers - part 1/N

[Ofek Shilon via Phabricator via llvm-commits]

OfekShilon marked an inline comment as done.
OfekShilon added a comment.

I apologize - I dropped this for too long and am having a hard time resurrecting it now. I'm closing this and will start again in a fresh review request in the near days.



================
Comment at: llvm/tools/opt-viewer/cpp_optimization_example/main.cc:5
+// Based on Roi Barkan - "Argument passing, core guidelines and concepts" - https://www.youtube.com/watch?v=uylFACqcWYI
+void scale_down(std::vector<double>& v, const double& a) {
+    for (auto& item : v) {
----------------
fhahn wrote:
> It would probably be good to format this with clang-format and the LLVM code style.
@fhahn How do I do that?


================
Comment at: llvm/tools/opt-viewer/cpp_optimization_example/main.cc:14
+    scale_down(v, v[0]);
+
+}
----------------
fhahn wrote:
> nit: stray new line?
fixed


================
Comment at: llvm/tools/opt-viewer/requirements.txt:3
+Pygments>=2.2.0
+#guppy>=0.1.11
----------------
fhahn wrote:
> Is this needed or not?
Needed, in parts not yet included in this first patch


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131518/new/

https://reviews.llvm.org/D131518