[PATCH] D135390: [SPIRV] Fix call lowering of "anonymous" functions

Michal Paszkowski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 8 19:16:48 PDT 2022


mpaszkowski marked 3 inline comments as done.
mpaszkowski added a comment.

Updated the patch with the following changes:

- Corrected formatting of the LIT test to match the style of other tests.
- Changed llvm_unreachable to report_fatal_error.
- Extracted some duplicate code into an util getFunctionGlobalIdentifier function.
- Added (for now) an assert masking sure the function passed into getFuncReg is not nullptr. Will rework some of this in the upcoming patch.

Thank you @andreytr and @arsenm for comments!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135390/new/

https://reviews.llvm.org/D135390



More information about the llvm-commits mailing list