[PATCH] D130006: [SPARC] Improve integer branch handling for v9 targets

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/Sparc/SparcISelLowering.cpp:3184
+      return expandSelectCC(MI, BB, SP::BPICC);
+    else
+      return expandSelectCC(MI, BB, SP::BCOND);
----------------
No return after else


================
Comment at: llvm/lib/Target/Sparc/SparcInstrInfo.cpp:291
+    unsigned Opc;
+    if (Subtarget.isV9()) {
+      // We need to know the operand width to emit the correct
----------------
Shouldn't rely on a subtarget check should rely on the opcode behaviors. Otherwise you are dependent on specific selection behavior 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130006/new/

https://reviews.llvm.org/D130006