[PATCH] D135515: [SPARC] Don't emit deprecated FP branches when targeting v9

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/Sparc/SparcISelLowering.cpp:3210
+      return expandSelectCC(MI, BB, SP::BPFCC);
+    else
+      return expandSelectCC(MI, BB, SP::FBCOND);
----------------
No else after return


================
Comment at: llvm/lib/Target/Sparc/SparcInstrInfo.cpp:185
           MachineOperand::CreateImm(isI64CondBranchOpcode(Opc) ? 64 : 32));
+  } else if (isV9) {
+      // v9 FP branches need an additional operand
----------------
I'm assuming it would still be valid to use the old opcodes on v9. You should explicitly handle the opcodes with the additional conditional register input, rather than relying on the subtarget check


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135515/new/

https://reviews.llvm.org/D135515