[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

Fri Oct 7 21:18:35 PDT 2022

zixuan-wu added a comment.

In D121445#3824657 <https://reviews.llvm.org/D121445#3824657>, @MaskRay wrote:

> mips computed sysroot from GCCInstallation very early in 2013 rG08450bd55ccdc4aee4f5f73cde97e25b3c4ce5b9 <https://reviews.llvm.org/rG08450bd55ccdc4aee4f5f73cde97e25b3c4ce5b9> and Android followed up in 2018 (D45291 <https://reviews.llvm.org/D45291>), but I am not sure this is the correct direction.
> They are to support very special distributions. Hard coding the file hierarchy for every Linux distribution just does not scale.
> I raised my concern on https://reviews.llvm.org/D134454#3824630 as well.
>
> With https://reviews.llvm.org/D134337 (default configuration file) we should move the logic to use a default configuration file instead.

It's fine for me to use config file. I only have 2 points.

1. I agree sysroot should be separated from GCC because sysroot is not dependent to GCC and there is even not gcc when we use llvm runtime. This rule should also apply to multilib logic. Sysroot can detect multilib path individually.
2. From user view,  it's not easy to add sysroot or config file path manually, so it needs good way to enable this functionality.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121445/new/

https://reviews.llvm.org/D121445