[PATCH] D135251: [LoongArch] Don't merge FrameIndex accesses into [F]{LD,ST}X

[wanglei via Phabricator via llvm-commits]

wangleiat added a comment.

In D135251#3844567 <https://reviews.llvm.org/D135251#3844567>, @xen0n wrote:

> In D135251#3844467 <https://reviews.llvm.org/D135251#3844467>, @SixWeining wrote:
>
>> Thanks for the fix.
>>
>> I tried to write a simpler test which can reproduce the crash.
>>
>>   define i8 @test(i64 %i) {
>>     %1 = alloca ptr 
>>     %2 = getelementptr inbounds i8, ptr %1, i64 %i
>>     %3 = load i8, ptr %2
>>     ret i8 %3
>>   }
>>
>> BTW. Seems @wangleiat has another approach to fix this issue. @wangleiat Do you have any comments?
>
> Nice. I simply minimized my cases with `bugpoint --run-llc`, although I suspected `alloca` may be the culprit but I didn't try to remove the array structure.
>
> As for which approach to choose for fixing this bug, I'm open to any better proposal. Maybe we can wait for @wangleiat to post his patch to compare.

This would be better.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135251/new/

https://reviews.llvm.org/D135251