[PATCH] D135497: [NFC][3/n] Remove enable-new-pm from Inline tests
Arthur Eubanks via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 7 19:43:41 PDT 2022
aeubanks added a comment.
the new pass manager inliner doesn't do alloca merging, see the comments around the `DisableInlinedAllocaMerging` in `Inliner.cpp`. so we can just delete those tests, including alloca-dbgdeclare-merge.ll
inline-{hot,cold}-callee.ll can be deleted, see https://reviews.llvm.org/D33157 where those tests are testing legacy PM-specific code paths
delete-call.ll/dead-calls-willreturn.ll test functionality added in https://reviews.llvm.org/rGeb9acbfb0522f4f69f1a11e47ebeda7f1a61e1df that's not present in the new PM pass. I tried seeing if it had any compile time impact <https://llvm-compile-time-tracker.com/compare.php?from=47b1623b1fc4b8aaa2d4c310bbc3a895cbb1f527&to=2b63b22798e5d0c8431737220f995dcf1237e4cd&stat=instructions> when ported to the new PM pass, it doesn't seem to, so no reason to port it, so we can drop those tests
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135497/new/
https://reviews.llvm.org/D135497
More information about the llvm-commits
mailing list