[PATCH] D135478: [AMDGPU] Make V_SAT_PK_U8_I16 a True16 Instruction

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 7 16:37:45 PDT 2022


arsenm added a comment.

In D135478#3843621 <https://reviews.llvm.org/D135478#3843621>, @Joe_Nash wrote:

> It's not clear to me if this instruction was ever selected. I don't see any ISel pattern or reference in tablegen or c++. In the synthesized tablgen defs, I see list<dag> Pattern = [(set i32:$vdst, (null_frag (i32 (VOP3Mods0 i32:$src0))))]; which I think doesn't get used because of the null_frag? Anyway, if it is being selected, do I need to update the pattern for the type change?

If it's not getting selected, it probably should be. I believe this corresponds to llvm.sadd.sat


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135478/new/

https://reviews.llvm.org/D135478



More information about the llvm-commits mailing list